Skip to content

Adds method chaining support to LightningModule.freeze() and LightningModule.unfreeze() by returning self #21469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bhimrazy merged 7 commits into from
Jan 12, 2026
Merged

Adds method chaining support to LightningModule.freeze() and LightningModule.unfreeze() by returning self #21469

bhimrazy merged 7 commits into from
Jan 12, 2026
+16 −8

Conversation

@GdoongMathew
Copy link
Contributor

@GdoongMathew GdoongMathew commented Jan 5, 2026 •
edited by github-actions bot
Loading

What does this PR do?

Fixes #21464

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21469.org.readthedocs.build/en/21469/

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Jan 5, 2026
@codecov
Copy link

codecov bot commented Jan 5, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79%. Comparing base (be2e8d0) to head (68b34da).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

❗ There is a different number of reports uploaded between BASE (be2e8d0) and HEAD (68b34da). Click for more details.

HEAD has 124 uploads less than BASE
Flag BASE (be2e8d0) HEAD (68b34da)
cpu 64 33
python 6 3
lightning_fabric 17 0
pytest 31 0
python3.10 6 3
lightning 29 15
python3.12 18 9
python3.12.7 17 9
python3.13 6 3
python3.11 11 6
Additional details and impacted files 
@@            Coverage Diff            @@
##           master   #21469     +/-   ##
=========================================
- Coverage      87%      79%     -8%     
=========================================
  Files         270      267      -3     
  Lines       24059    24004     -55     
=========================================
- Hits        20855    18955   -1900     
- Misses       3204     5049   +1845

@bhimrazy bhimrazy changed the title return self instance in freeze and unfreeze method Adds method chaining support to LightningModule.freeze() and LightningModule.unfreeze() by returning self Jan 12, 2026
bhimrazy
bhimrazy approved these changes Jan 12, 2026
View reviewed changes
Copy link
Collaborator

@bhimrazy bhimrazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tchaton
tchaton approved these changes Jan 12, 2026
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !

@bhimrazy bhimrazy merged commit 36998f5 into Lightning-AI:master Jan 12, 2026
90 checks passed
@GdoongMathew GdoongMathew deleted the feat/freeze_return branch January 12, 2026 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tchaton tchaton tchaton approved these changes

@bhimrazy bhimrazy bhimrazy approved these changes

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

Assignees

No one assigned

Labels

pl Generic label for PyTorch Lightning package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Return Self type in LightningModule.freeze() and LightningModule.unfreeze method

3 participants

@GdoongMathew @tchaton @bhimrazy